Skip to content

Fix monitoring runs not starting due to missing terms - #40

Merged
scottfrasso merged 1 commit into
mainfrom
fix/runs-not-starting
Mar 1, 2026
Merged

Fix monitoring runs not starting due to missing terms#40
scottfrasso merged 1 commit into
mainfrom
fix/runs-not-starting

Conversation

@scottfrasso

Copy link
Copy Markdown
Contributor

Summary

  • Monitoring runs silently skipped when no terms were configured because create_project() seeded default providers but not a default monitoring term
  • Auto-seeds a default term from brand name on project creation so the first "Run Now" click works
  • Returns a detailed 400 error when triggering monitoring without terms, explaining exactly how to fix it
  • Creates a critical configuration_error alert when scheduled runs skip due to missing config
  • Adds client-side validation in the setup wizard requiring at least one monitoring term

Test plan

  • All 215 existing tests pass
  • New test: test_trigger_monitor_no_terms_returns_400 verifies 400 response
  • Extended test_no_terms_skips_run verifies alert creation
  • Manual QA: setup wizard blocks submission without terms
  • Manual QA: project creation auto-seeds term from brand name
  • Manual QA: "Monitor Now" on termless project shows toast with instructions
  • Manual QA: scheduled run skip creates visible alert in AlertsFeed
  • ruff, tsc --noEmit pass clean

🤖 Generated with Claude Code

Monitoring runs silently skipped when no terms were configured because
create_project() seeded default providers but not a default term. This
adds three layers of protection:

1. Auto-seed a default monitoring term from brand name on project creation
2. Validate terms exist before triggering manual runs (400 with instructions)
3. Create a critical configuration_error alert when scheduled runs skip
4. Require at least one term in the setup wizard with client-side validation

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@scottfrasso

Copy link
Copy Markdown
Contributor Author

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@scottfrasso
scottfrasso merged commit 20c67af into main Mar 1, 2026
4 checks passed
@scottfrasso
scottfrasso deleted the fix/runs-not-starting branch March 1, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant