Fix monitoring runs not starting due to missing terms - #40
Merged
Conversation
Monitoring runs silently skipped when no terms were configured because create_project() seeded default providers but not a default term. This adds three layers of protection: 1. Auto-seed a default monitoring term from brand name on project creation 2. Validate terms exist before triggering manual runs (400 with instructions) 3. Create a critical configuration_error alert when scheduled runs skip 4. Require at least one term in the setup wizard with client-side validation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_project()seeded default providers but not a default monitoring termconfiguration_erroralert when scheduled runs skip due to missing configTest plan
test_trigger_monitor_no_terms_returns_400verifies 400 responsetest_no_terms_skips_runverifies alert creation🤖 Generated with Claude Code