Skip to content

refactor(66): remove unused geometry property #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eschuh wants to merge 1 commit into from
Closed

refactor(66): remove unused geometry property #118

eschuh wants to merge 1 commit into from

Conversation

@eschuh
Copy link
Collaborator

@eschuh eschuh commented Jun 5, 2025

No description provided.

@ger-benjamin
Copy link
Member

ger-benjamin commented Jun 5, 2025 •
edited
Loading

I'm not sure you can simply remove it. This code is related to the addition in this PR: camptocamp/bridge-style#54 and this geometry was used to solve an issue. In this PR, you have a link to a ticket. Do you have access to it ? Maybe you can try on the mentionned layer (alg_wtkwildkorr_01.lyrx ) ?

@eschuh
Copy link
Collaborator Author

eschuh commented Jun 5, 2025

I'm not sure you can simply remove it. This code is related to the addition in this PR: camptocamp/bridge-style#54 and this geometry was used to solve an issue. In this PR, you have a link to a ticket. Do you have access to it ? Maybe you can try on the mentionned layer (alg_wtkwildkorr_01.lyrx ) ?

Thanks.. yes I have access. I will add a test and try to fix it!

ger-benjamin
ger-benjamin requested changes Jun 6, 2025
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change or feedback needed.

@eschuh
Copy link
Collaborator Author

eschuh commented Jan 6, 2026

@ger-benjamin I close this PR as it did not fix the problem.

@eschuh eschuh closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ger-benjamin ger-benjamin ger-benjamin requested changes

@myriamfischer myriamfischer Awaiting requested review from myriamfischer

Assignees

@eschuh eschuh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eschuh @ger-benjamin