-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add Discord-style slash commands to QChat #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Implements a comprehensive slash command system inspired by Discord, adding fun interactions and useful utilities to the chat. Features: - Fun text commands: /shrug, /tableflip, /lenny, /yolo - Random commands: /flip (coin flip), /roll (dice), /8ball (magic 8-ball) - /list command: displays all available commands with descriptions - Autocomplete: automatic command suggestions when typing New files: - qchat/logic/slash_commands.py: Command handler system - docs/usage/slash_commands.md: User documentation Modified: - qchat/gui/dck_qchat.py: Command interception and weather layer creation Technical details: - Extensible architecture for easy command additions - Comprehensive error handling Examples: - /shrug → sends "¯\_(ツ)_/¯" - /roll 2d20 → rolls 2 dice with 20 faces
for more information, see https://pre-commit.ci
gounux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lbartoletti 💯
First review round, did not check out locally to test it but will do it and try to review more deeply.
Co-authored-by: Guilhem Allaman <[email protected]> Signed-off-by: Loïc Bartoletti <[email protected]>
gounux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @lbartoletti !
I could checkout and test, works like a charm, it's funny and opens the way to new commands ;)
Just a small point about the QCompleter, which sometimes avoids clearing the line edit input before sending the message.
Nothing blocking TBH, if you know how to fix that it'd be nice. But I believe that we can also merge as is, it's your call !
gounux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM, thanks and congrats for the first contribution @lbartoletti :)
Hoping we'll see you again around here in the future !
Implements a comprehensive slash command system inspired by Discord, adding fun interactions and useful utilities to the chat.
Features:
New files:
Modified:
Technical details:
Examples:
This is not sponsored by :