Feat/multiple vehicles#38
Conversation
Fixes multiple resolve-after-reject bugs and fixes vin decoding bug in 4.3.x where all vehicles were interpreted as a Model 3
Adds left and right arrows which will change `vehicleIdx`. This is not very graceful; user feedback isn't immediate and could use some work. But it does persist the index between runs, so it's very useful there.
|
Thanks for taking the time doing this. I apologize for the long delay. I've not being active on this project for a while. Are you interested in having write access to this repo? I will review this PR soon anyway. |
|
That'd be great. I know how it is. I can't promise that I'll be all that active either, but I am interested in merging in the changes from Lunars as well which supports direct-to-vehicle communication (instead of just Tesla API). To do so would require an additional "add vehicle" screen with more than just the login option. That could make this quite a versatile tool. |
|
@STRML Done! Invite sent. Let me know when you get to a point you want me to release a new version (then auto-update will kick-in for all clients). I'm more than happy to let you do that as well but we need to handle the developer certificate stuff for mac and windows. Feel free to merge this change you did and any others you see fit. I can launch a new release once you ask me to. In regards to no commitment promises, I totally understand =D |
|
PS: I will try to setup GitHub actions to deploy the release automatically at some point... |
|
Can this also handle multiple cars across multiple Tesla accounts? |
3 participants
Adds left and right arrows which will change
vehicleIdx.This is not very graceful; user feedback isn't immediate and could use some work. But it does persist the index between runs, so it's very useful there.
Also fixes some bugs related to tesla-api, which unnecessarily wrapped callbacks with promises when
*Asyncmethods were available, and would resolve after reject. TeslaJS also had a bug with decoding the model type that was returning Model 3 for all VINs.Fixes #37
*clicked rt button*, then...