feat: Fix partner-token header#10
Open
leandro-costa-oliveira wants to merge 5 commits intogerencianet:mainfrom
Open
feat: Fix partner-token header#10leandro-costa-oliveira wants to merge 5 commits intogerencianet:mainfrom
leandro-costa-oliveira wants to merge 5 commits intogerencianet:mainfrom
Conversation
leandro-costa-oliveira
changed the title
leandro-costa-oliveira
changed the title
leandro-costa-oliveira
force-pushed
the
feat-test-partner-token
branch
from
018e95c to
0a568c0
Compare
leandro-costa-oliveira
force-pushed
the
feat-test-partner-token
branch
from
bffcd1c to
1190710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
At index.ts, the Endpoints object is instantiated with
credentialsbeen passed as param, but the partnerToken is never set to it. So we passed down thepartnerTokenfrom the options object to the credentails.gn-api-sdk-typescript/index.ts
Line 36 in 403f87a
Changes
[x] Adding test cases to validate the header
partner-token.[x] Adding test cases to validate Endpoint constructor params.
[x] Passing down
partnerTokenfrom options tocredentialsobject, which is used on Endpoints.Tests/QA