Skip to content

Conversation

@gerlero
Copy link
Owner

@gerlero gerlero commented Mar 3, 2025

As part of openjournals/joss-reviews#7633, make the following proposed changes to the paper.

From #316 (comment)

  • PAPER: Comment on why an external parser was written instead of C++ bindings for OpenFOAM's own parser.
  • PAPER: Mention that looping over a TimeDirectory will iterate over the reconstructed time folders.
  • PAPER: soften language on statement of what files FoamFile can parse & refer readers to FoamFile API docs.
  • PAPER: fix inconsistency numpy.ndarray vs np.ndarray.

From #317 (comment):

  • PAPER: mention other OpenFOAM-related Python packages in the statement of need, including fluidfoam and fluidsimfoam.

From #318 (comment):

  • PAPER: mention hardware used to measure the reported speedup.

@gerlero gerlero force-pushed the paper branch 2 times, most recently from fcf228f to 7b4123c Compare March 5, 2025 13:55
@AndreWeiner
Copy link

AndreWeiner commented Mar 6, 2025

@gerlero the PR looks good from my point of view.

@Failxxx
Copy link
Contributor

Failxxx commented Apr 5, 2025

Looks good to me 👍🏻

@gerlero gerlero merged commit fbe903b into joss Apr 23, 2025
1 check passed
@gerlero gerlero deleted the paper branch April 23, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants