Skip to content

Extract deployment_ready conditional into named variable #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nosredna123 merged 3 commits into from
Dec 14, 2025
Merged

Extract deployment_ready conditional into named variable #9

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
605ad18
Initial plan
Copilot Dec 14, 2025
d4c9f5d
refactor: Extract deployment_ready logic for better readability
Copilot Dec 14, 2025
691e1b5
Update baes/core/enhanced_runtime_kernel.py
nosredna123 Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions baes/core/enhanced_runtime_kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,6 +938,9 @@ def _execute_coordination_plan(
task_name,
)

# Extract deployment_ready logic for better readability
deployment_ready = False if force_accepted else review_result.get("data", {}).get("deployment_ready", False)

results.append(
{
"task": task_name,
Expand All @@ -946,9 +949,7 @@ def _execute_coordination_plan(
"techlead_approved": True,
"force_accepted": force_accepted,
"final_review": True,
"deployment_ready": review_result.get("data", {}).get(
"deployment_ready", False
) if not force_accepted else False, # Force-accepted means not truly deployment ready
"deployment_ready": deployment_ready,
"system_quality_score": quality_score,
"retry_count": retry_count,
# Include force-accept metadata if applicable
Expand Down