-
Notifications
You must be signed in to change notification settings - Fork 76
Adding (.qs2) functionality - Fix #471 #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
{qs2} is the successor to the {qs} package that has integrated functionality in {rio} currently. The author of the {qs} package will be deprecating it, so i wanted to get ahead of that and make a PR for his replacement package for {qs}. See below for reference to his deprecation announcement
Note: other packages like {pins} have already begun to account for this move.
qsbase/qs#103
|
I made an error in the description file when adding myself at ctb, fixing now |
removing "Quick and Future-Proof" per suggestion
|
I resolved as many discussions as I could. Please advise if there is more I need to do in regards to rendering the README. Thank you |
Please render it. Even better, please either use Rscript data-raw/convert.R
Rscript -e "devtools::build_readme()" Thank you very much! |
|
@chainsawriot - quick Q: looks like some of the code compiles rds and qs2 together now because after removing the "(Quick and future-proof)" suffix, they are both named "Serialized R Objects". Do you have any suggestions for how differentiate the names that doesn't use "(Quick and future-proof)" example: |
Perhaps |
… name collisions Also updated using devtools::document() which forced rio.Rd to be re-compiled
|
I believe I have resolved all questions and suggestions! Please let me know if you catch anything else! Thanks |
{qs2} is the successor to the {qs} package that has integrated functionality in {rio} currently. The author of the {qs} package will be deprecating it, so i wanted to get ahead of that and make a PR for his replacement package for {qs}. See below for reference to his deprecation announcement
Note: other packages like {pins} have already begun to account for this move.
qsbase/qs#103
I think I covered my bases in needed additions/changes to all the files, but please let me know if I missed something.
@frankiethull - this will satisfy your request, correct?