feat: auto-swaps #1266
Open
feat: auto-swaps #1266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
reviewed
Apr 18, 2025
im-adithya
reviewed
Apr 18, 2025
jackstar12
reviewed
Apr 22, 2025
rolznz
reviewed
Apr 23, 2025
rolznz
reviewed
Apr 23, 2025
rolznz
reviewed
Apr 23, 2025
rolznz
reviewed
Apr 23, 2025
rolznz
reviewed
Apr 23, 2025
rolznz
reviewed
Apr 23, 2025
im-adithya
reviewed
Apr 23, 2025
|
You can take this as a reference for implementing the fee check: BoltzExchange/boltz-client#423 |
rolznz
reviewed
May 8, 2025
| @@ -435,7 +435,7 @@ func getMaxTotalRoutingFeeLimit(amountMsat uint64) ldk_node.MaxTotalRoutingFeeLi | |||
| } | |||
| } | |||
|
|
|||
| func (ls *LDKService) SendPaymentSync(ctx context.Context, invoice string, amount *uint64) (*lnclient.PayInvoiceResponse, error) { | |||
| func (ls *LDKService) SendPaymentSync(ctx context.Context, invoice string, amount *uint64, isHoldInvoice bool) (*lnclient.PayInvoiceResponse, error) { | |||
There was a problem hiding this comment.
I'm not sure this is the best way to do it. This method is SendPaymentSync but now we are basically doing an async payment, right?
There was a problem hiding this comment.
edit: can we change it to timeout rather than isHoldInvoice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
Shift Swaps from settings(Agreeed to do in follow-up)Add option to do one-time swaps(Agreeed to do in follow-up)Minor
LDK_NETWORKconfig var should now beNETWORKTesting