fix: show total subwallet count instead of page count#2034
fix: show total subwallet count instead of page count#2034kanishka0411 wants to merge 1 commit intogetAlby:masterfrom
Conversation
📝 WalkthroughWalkthroughThe change updates the subwallet count display from using the length of the currently-loaded subwalletApps array to using appsData.totalCount, ensuring the correct total number of subwallets is shown regardless of pagination. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@kanishka0411 thanks for the PR. I think the total assets under management is also wrong. But I need to think about what the best way to do it is. |
|
Hey @kanishka0411, thanks for your contribution, but I'm closing this in favour of #2057 as this is a partial solution! |
Fixes #2031
The "Number of Sub-wallets" card was displaying only the count of the current page (max 20) instead of the total count. Changed from
subwalletApps.lengthtoappsData.totalCount.Summary by CodeRabbit
Bug Fixes