Skip to content

fix: show total subwallet count instead of page count#2034

Closed
kanishka0411 wants to merge 1 commit intogetAlby:masterfrom
kanishka0411:fix/subwallet-count-display
Closed

fix: show total subwallet count instead of page count#2034
kanishka0411 wants to merge 1 commit intogetAlby:masterfrom
kanishka0411:fix/subwallet-count-display

Conversation

@kanishka0411
Copy link

@kanishka0411 kanishka0411 commented Feb 5, 2026

Fixes #2031
The "Number of Sub-wallets" card was displaying only the count of the current page (max 20) instead of the total count. Changed from subwalletApps.length to appsData.totalCount.

Summary by CodeRabbit

Bug Fixes

  • Improved accuracy of the sub-wallets count display by updating the data source used for calculating the total number of sub-wallets shown to users.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

The change updates the subwallet count display from using the length of the currently-loaded subwalletApps array to using appsData.totalCount, ensuring the correct total number of subwallets is shown regardless of pagination.

Changes

Cohort / File(s) Summary
Subwallet Count Display
frontend/src/screens/subwallets/SubwalletList.tsx
Changed subwallet count source from subwalletApps.length to appsData.totalCount to correctly display total count instead of only the first page's wallets.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A count that was stuck on twenty,
Now shows all the wallets aplenty,
From appsData we spring,
The true total to bring—
Six hundred and counting, how plenty! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the core fix: changing from displaying page count to total subwallet count, which matches the actual code change.
Linked Issues check ✅ Passed The code change directly addresses issue #2031 by replacing subwalletApps.length with appsData.totalCount to display total subwallets instead of page count.
Out of Scope Changes check ✅ Passed The single line change is tightly scoped to fixing the subwallet count display as specified in issue #2031; no extraneous modifications are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rolznz
Copy link
Contributor

rolznz commented Feb 9, 2026

@kanishka0411 thanks for the PR. I think the total assets under management is also wrong. But I need to think about what the best way to do it is.

@im-adithya
Copy link
Member

Hey @kanishka0411, thanks for your contribution, but I'm closing this in favour of #2057 as this is a partial solution!

@im-adithya im-adithya closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Subwallet page only shows count of wallets on first page

3 participants

Comments