feat: handle sub sat amounts #3455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumi
reviewed
Oct 24, 2025
Contributor
|
@copilot review this PR based on the bolt11 spec: https://www.bolt11.org/ |
Contributor
|
@reneaaron I've opened a new pull request, #3456, to work on those changes. Once the pull request is ready, I'll request review from you. |
Contributor
Author
|
@reneaaron copilot created empty pr instead of reviewing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bolt-11 signet doesnt set "invoice.satoshis" if sub sat amount is passed. in that case we have only use millisatoshi.
this pr adds support to use msats if satoshis field is not present and hence we show proper amount while paying invoices
not tested end to end