Translations update from Hosted Weblate#3579
Conversation
Currently translated at 100.0% (773 of 773 strings) Co-authored-by: BSN ∞/21M ₿ <nc-kuttigfa@netcologne.de> Translate-URL: https://hosted.weblate.org/projects/getalby-lightning-browser-extension/getalby-lightning-browser-extension/de/ Translation: getAlby - lightning-browser-extension/getAlby - lightning-browser-extension
📝 WalkthroughWalkthroughThe German ChangesGerman choose-path localization
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/i18n/locales/de/translation.json`:
- Around line 870-876: Update the German translation entries for the connection
UI around “connect” and “other.description” to use consistent informal “du/dein”
address and matching connection terminology. Preserve the existing meaning while
aligning these labels with the surrounding informal German strings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2cf4a3d7-633a-425f-a4a2-3a1ec3377957
📒 Files selected for processing (1)
src/i18n/locales/de/translation.json
| "connect": "Schließe es an", | ||
| "prompt": "Hast du schon ein Alby-Konto?" | ||
| }, | ||
| "title": "Alby Extension mit einer Wallet verbinden" | ||
| "title": "Alby Extension mit einer Wallet verbinden", | ||
| "other": { | ||
| "title": "Hast du schon eine Wallet?", | ||
| "description": "Verbinden Sie Ihren Alby Hub oder eine beliebige andere Lightning-Wallet.", |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Keep the new labels consistent with the surrounding informal German UI.
Schließe es an and Verbinden Sie Ihren mix different connection wording and formal/informal address, while the surrounding strings use du/dein. Prefer consistent wording such as:
Proposed translation
- "connect": "Schließe es an",
+ "connect": "Verbinden",
...
- "description": "Verbinden Sie Ihren Alby Hub oder eine beliebige andere Lightning-Wallet.",
+ "description": "Verbinde deinen Alby Hub oder eine andere Lightning-Wallet.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "connect": "Schließe es an", | |
| "prompt": "Hast du schon ein Alby-Konto?" | |
| }, | |
| "title": "Alby Extension mit einer Wallet verbinden" | |
| "title": "Alby Extension mit einer Wallet verbinden", | |
| "other": { | |
| "title": "Hast du schon eine Wallet?", | |
| "description": "Verbinden Sie Ihren Alby Hub oder eine beliebige andere Lightning-Wallet.", | |
| "connect": "Verbinden", | |
| "prompt": "Hast du schon ein Alby-Konto?" | |
| }, | |
| "title": "Alby Extension mit einer Wallet verbinden", | |
| "other": { | |
| "title": "Hast du schon eine Wallet?", | |
| "description": "Verbinde deinen Alby Hub oder eine andere Lightning-Wallet.", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/i18n/locales/de/translation.json` around lines 870 - 876, Update the
German translation entries for the connection UI around “connect” and
“other.description” to use consistent informal “du/dein” address and matching
connection terminology. Preserve the existing meaning while aligning these
labels with the surrounding informal German strings.
Translations update from Hosted Weblate for getAlby - lightning-browser-extension/getAlby - lightning-browser-extension.
Current translation status:
Summary by CodeRabbit