Skip to content

Translations update from Hosted Weblate#3579

Open
weblate wants to merge 1 commit into
getAlby:masterfrom
weblate:weblate-getalby-lightning-browser-extension-getalby-lightning-browser-extension
Open

Translations update from Hosted Weblate#3579
weblate wants to merge 1 commit into
getAlby:masterfrom
weblate:weblate-getalby-lightning-browser-extension-getalby-lightning-browser-extension

Conversation

@weblate

@weblate weblate commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Translations update from Hosted Weblate for getAlby - lightning-browser-extension/getAlby - lightning-browser-extension.

Current translation status:

Weblate translation status

Summary by CodeRabbit

  • New Features
    • Expanded German onboarding translations for available connection paths.
    • Added clearer descriptions and prompts for Alby and Alby Hub options.
    • Added a new “Other” option with supporting text.
    • Included a “Get started” call to action for Alby Hub.

Currently translated at 100.0% (773 of 773 strings)

Co-authored-by: BSN ∞/21M ₿ <nc-kuttigfa@netcologne.de>
Translate-URL: https://hosted.weblate.org/projects/getalby-lightning-browser-extension/getalby-lightning-browser-extension/de/
Translation: getAlby - lightning-browser-extension/getAlby - lightning-browser-extension
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The German choose_path translations now include connection prompts for Alby, structured text for the other option, and expanded AlbyHub onboarding content with a get-started label.

Changes

German choose-path localization

Layer / File(s) Summary
Expand choose-path option text
src/i18n/locales/de/translation.json
The Alby option gains connection and prompt text, the other option receives title, description, and connection text, and AlbyHub gains onboarding description and a get-started label.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: pavanjoshi914

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description omits the template's required sections for changes, type, testing, screenshots, and checklist. Add the missing template sections with a change summary, issue link if any, type of change, testing steps, screenshots if relevant, and checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the PR's translation update from Hosted Weblate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/i18n/locales/de/translation.json`:
- Around line 870-876: Update the German translation entries for the connection
UI around “connect” and “other.description” to use consistent informal “du/dein”
address and matching connection terminology. Preserve the existing meaning while
aligning these labels with the surrounding informal German strings.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2cf4a3d7-633a-425f-a4a2-3a1ec3377957

📥 Commits

Reviewing files that changed from the base of the PR and between 01b4ca3 and a79f2e6.

📒 Files selected for processing (1)
  • src/i18n/locales/de/translation.json

Comment on lines +870 to +876
"connect": "Schließe es an",
"prompt": "Hast du schon ein Alby-Konto?"
},
"title": "Alby Extension mit einer Wallet verbinden"
"title": "Alby Extension mit einer Wallet verbinden",
"other": {
"title": "Hast du schon eine Wallet?",
"description": "Verbinden Sie Ihren Alby Hub oder eine beliebige andere Lightning-Wallet.",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Keep the new labels consistent with the surrounding informal German UI.

Schließe es an and Verbinden Sie Ihren mix different connection wording and formal/informal address, while the surrounding strings use du/dein. Prefer consistent wording such as:

Proposed translation
-        "connect": "Schließe es an",
+        "connect": "Verbinden",
...
-        "description": "Verbinden Sie Ihren Alby Hub oder eine beliebige andere Lightning-Wallet.",
+        "description": "Verbinde deinen Alby Hub oder eine andere Lightning-Wallet.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"connect": "Schließe es an",
"prompt": "Hast du schon ein Alby-Konto?"
},
"title": "Alby Extension mit einer Wallet verbinden"
"title": "Alby Extension mit einer Wallet verbinden",
"other": {
"title": "Hast du schon eine Wallet?",
"description": "Verbinden Sie Ihren Alby Hub oder eine beliebige andere Lightning-Wallet.",
"connect": "Verbinden",
"prompt": "Hast du schon ein Alby-Konto?"
},
"title": "Alby Extension mit einer Wallet verbinden",
"other": {
"title": "Hast du schon eine Wallet?",
"description": "Verbinde deinen Alby Hub oder eine andere Lightning-Wallet.",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/i18n/locales/de/translation.json` around lines 870 - 876, Update the
German translation entries for the connection UI around “connect” and
“other.description” to use consistent informal “du/dein” address and matching
connection terminology. Preserve the existing meaning while aligning these
labels with the surrounding informal German strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant