Conversation
🔍 Deadcode AnalysisFound 3 unreachable functions in the backend. View detailsOnly remove deadcode that you know is 100% no longer used.
|
|
Container images for this PR have been built successfully!
Built from commit 65ff15a |
Additional Comments (1)
The "Always" and "Never" labels use This same hardcoded string also appears at:
Prompt To Fix With AIThis is a comment left during a code review.
Path: frontend/src/lib/components/deploy-split-button/deploy-split-button.svelte
Line: 475-479
Comment:
**Hardcoded "Missing" label is not i18n-friendly**
The "Always" and "Never" labels use `m.common_always()` / `m.common_never()`, but the "Missing" label is a hardcoded English string in three places (`deploy-split-button.svelte`, `action-buttons.svelte`, and `DockerTab.svelte`). A corresponding message key (e.g. `deploy_pull_policy_missing_label`) should be added to `en.json` and used here for consistency.
This same hardcoded string also appears at:
- `frontend/src/lib/components/action-buttons.svelte` (two instances in the mobile and desktop dropdown menus)
- `frontend/src/routes/(app)/environments/[id]/components/DockerTab.svelte` (`label: 'Missing'` in `deployPullPolicyOptions`)
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
c172c1e to
bec81dd
Compare
bec81dd to
65ff15a
Compare

What This PR Implements
Related issue
Related Issue
Fixes # #1270
Changes Made
Testing Done
./scripts/development/dev.sh startjust lint all)just test backendChecklist
mainbranchAI Tool Used (if applicable)
AI Tool:
Assistance Level:
What AI helped with:
I reviewed and edited all AI-generated output:
I ran all required tests and manually verified changes:
Additional Context
Disclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
Greptile Summary
This PR implements a configurable compose up button that allows users to customize Docker deployment behavior with pull policies and container recreation options.
Changes:
defaultDeployPullPolicy(missing/always/never) to control default image pull behaviorpull_policy→ user override → admin default → fallback to "missing"Implementation:
DeployOptionstype with validation, updated service layer and compose commandsdeployOptionsStorefor state management, split button component, integrated across all deploy UIsConfidence Score: 4/5
Important Files Changed
DefaultDeployPullPolicyfield with proper validation binding tagDeployOptionsstruct withPullPolicyandForceRecreatefields, proper validationDeployProjectto accept options, addednormalizeDeployPullPolicyInternal, correct precedence logicforceRecreateparameter toComposeUp, sets recreate policy to force when enabledDeployProjectOptionstype, updateddeployProjectmethod with overloads for options supportLast reviewed commit: bec81dd