fix(PoweredByFider): preserve semver pre-release suffix in footer#1581
Open
hodyhq wants to merge 2 commits into
Open
fix(PoweredByFider): preserve semver pre-release suffix in footer#1581hodyhq wants to merge 2 commits into
hodyhq wants to merge 2 commits into
Conversation
The footer's version display used `version.split("-")[0]` to strip the
trailing commit hash, but that also strips every other `-`-separated
segment. Versions like `v0.35.0-rc.1-abc1234` collapse to `v0.35.0`,
hiding meaningful pre-release markers (rc, beta, alpha, custom build
tags, etc.).
Switched to a regex that strips only a trailing commit-hash segment
(7+ hex chars at the end of the string). All other suffixes survive:
v0.35.0-abc1234 -> v0.35.0 (unchanged behavior)
v0.35.0-rc.1-abc1234 -> v0.35.0-rc.1 (previously: v0.35.0)
v0.35.0-rc.1 -> v0.35.0-rc.1 (no hash to strip)
dev -> dev (unchanged behavior)
Closes the regression introduced for self-hosted builds whose
VERSION arg uses semver pre-release tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The footer's version display used
version.split("-")[0]to strip the trailing commit hash, but that also strips every other--separated segment. Versions likev0.35.0-rc.1-abc1234collapse tov0.35.0, hiding meaningful pre-release markers (rc, beta, alpha, custom build tags, etc.).Switched to a regex that strips only a trailing commit-hash segment (7+ hex chars at the end of the string). All other suffixes survive:
v0.35.0-abc1234 -> v0.35.0 (unchanged behavior)
v0.35.0-rc.1-abc1234 -> v0.35.0-rc.1 (previously: v0.35.0)
v0.35.0-rc.1 -> v0.35.0-rc.1 (no hash to strip)
dev -> dev (unchanged behavior)
Closes the regression introduced for self-hosted builds whose VERSION arg uses semver pre-release tags.
Issue: