2752 #2753
Open
2752 #2753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@getgauge/taiko-contributors Please check the pr |
Signed-off-by: Tanuja Viswanadhapalli <tanuja.viswanadhapalli@omnicell.com>
Signed-off-by: Tanuja Viswanadhapalli <tanuja.viswanadhapalli@omnicell.com>
Signed-off-by: Tanuja Viswanadhapalli <tanuja.viswanadhapalli@omnicell.com>
Signed-off-by: Tanuja Viswanadhapalli <tanuja.viswanadhapalli@omnicell.com>
Member
|
@tanuja-intellicore thanks for the PR can you look at the test failures? https://github.com/getgauge/taiko/actions/runs/15137304825/job/42613244355?pr=2753 |
Author
|
I have seen the failures and most of them are failing with beforeunload issue. I have raised the pr to accept the beforeunload after closing the browser |
Contributor
|
@tanuja-intellicore, @zabil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is for fixing the below issue. I have validated this fix and its working as expected
Error: There is no handler registered for beforeunload popup displayed on the page XXXXXX
This might interfere with your test flow. You can use Taiko's beforeunload API to handle this popup.
Please visit https://docs.taiko.dev/#beforeunload for more details
at Chrome. (/Users/19596/suse-run-final/ng-acceptance-tests/node_modules/taiko/lib/handlers/pageHandler.js:81:13)
at Chrome.emit (node:events:519:35)
at Chrome.emit (node:domain:489:12)
at Chrome._handleMessage (/Users/19596/suse-run-final/ng-acceptance-tests/node_modules/chrome-remote-interface/lib/chrome.js:287:18)
at WebSocket. (/Users/19596/suse-run-final/ng-acceptance-tests/node_modules/chrome-remote-interface/lib/chrome.js:240:22)
at WebSocket.emit (node:events:507:28)
at WebSocket.emit (node:domain:489:12)
at Receiver.receiverOnMessage (/Users/19596/suse-run-final/ng-acceptance-tests/node_modules/chrome-remote-interface/node_modules/ws/lib/websocket.js:1070:20)
at Receiver.emit (node:events:507:28)
at Receiver.emit (node:domain:489:12)
at Receiver.dataMessage (/Users/19596/suse-run-final/ng-acceptance-tests/node_modules/chrome-remote-interface/node_modules/ws/lib/receiver.js:517:14)
at Receiver.getData (/Users/19596/suse-run-final/ng-acceptance-tests/node_modules/chrome-remote-interface/node_modules/ws/lib/receiver.js:435:17)
at Receiver.startLoop (/Users/19596/suse-run-final/ng-acceptance-tests/node_modules/chrome-remote-interface/node_modules/ws/lib/receiver.js:143:22)
at Receiver._write (/Users/19596/suse-run-final/ng-acceptance-tests/node_modules/chrome-remote-interface/node_modules/ws/lib/receiver.js:78:10)
at writeOrBuffer (node:internal/streams/writable:570:12)
at _write (node:internal/streams/writable:499:10)
@getgauge/taiko-contributors