Add method to get route by language #3188
Draft
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just an idea on how [redirect problem](https://github.com/getgrav/grav/issues/3180) might be fixed maybe. Or at least partially. Although this doesn't work - couldn't figure out how to get parent. Without the parent, `route()` returns just a home route. Maybe someone could take this over, or tell me the approach is completely wrong :) But that issue really needs to be fixed. Otherwise I'll have to search for alternatives and I really like Grav otherwise, so it would be sad if I couldn't publish my page and had to ditch a few weeks work :( Also `Page::init()` calls `$this->id($this->modified() . md5($this->filePath()))`, but it gets overwritten, because `$this->id` doesn't exist yet, so added a check in `Page::id()`
Contributor
|
Parent needs to be instantiated, no? I would assume that this goes into the comprehensive work on improving multi-language, @ricardo118? Both pull requests and related issues address deficiencies in current language-handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an idea on how redirect problem might be fixed maybe. Or at least partially.
Although this doesn't work - couldn't figure out how to get parent. Without the parent,
route()returns just a home route.Maybe someone could take this over, or tell me the approach is completely wrong :) But that issue really needs to be fixed. Otherwise I'll have to search for alternatives and I really like Grav, so it would be sad if I couldn't publish my page and had to ditch a few weeks work :(
Also
Page::init()calls$this->id($this->modified() . md5($this->filePath())), but it gets overwritten, because$this->iddoesn't exist yet, so added a check inPage::id()