Update PHP version requirement for grav 1.7#4029
Open
Rotzbua wants to merge 1 commit intogetgrav:1.7.50from
Open
Update PHP version requirement for grav 1.7#4029Rotzbua wants to merge 1 commit intogetgrav:1.7.50from
Rotzbua wants to merge 1 commit intogetgrav:1.7.50from
Conversation
highest supported php version is 8.3 as mentioned in getgrav#3995
There was a problem hiding this comment.
Pull request overview
Updates Grav’s documented PHP requirements to reflect the highest PHP version currently considered supported/tested (per #3995) in the project’s primary README.
Changes:
- Adjusted the README “Requirements” PHP version line to specify an upper bound of PHP 8.3.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Requirements | ||
|
|
||
| - PHP 7.3.6 or higher. Check the [required modules list](https://learn.getgrav.org/basics/requirements#php-requirements) | ||
| - PHP 7.3.6 to 8.3. Check the [required modules list](https://learn.getgrav.org/basics/requirements#php-requirements) |
There was a problem hiding this comment.
The README now states an upper bound of PHP 8.3, but the project’s actual runtime constraint in composer.json is "php": "^7.3.6 || ^8.0" (no 8.3 max). This makes the Requirements section misleading for users/installers. Consider rewording to something like "PHP 7.3.6 or higher (tested/supported up to 8.3)" unless you also plan to enforce an upper bound in composer.json.
Suggested change
| - PHP 7.3.6 to 8.3. Check the [required modules list](https://learn.getgrav.org/basics/requirements#php-requirements) | |
| - PHP 7.3.6 or higher (tested/supported up to 8.3). Check the [required modules list](https://learn.getgrav.org/basics/requirements#php-requirements) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
highest supported php version is 8.3 as mentioned in #3995