Update REAMDE.md: Misleading example correction.#214
Open
Yadu Nandan (Y-D-U) wants to merge 2 commits into
Open
Update REAMDE.md: Misleading example correction.#214Yadu Nandan (Y-D-U) wants to merge 2 commits into
Yadu Nandan (Y-D-U) wants to merge 2 commits into
Conversation
While using this connector, went into the corrected example and found it misleading. Will be useful if corrected
Update README.md: Misleading Example Correction
| For Example: | ||
| `` | ||
| http://localhost:8080/client/service?id=1&uuid=2 | ||
| http://localhost:8080/client/service?id=1&id=2 |
There was a problem hiding this comment.
Thanks for noticing the error!
The example above has join condition o.id = c.id AND o.id2 = c.id2 so I guess it should be:
http://localhost:8080/client/service?id=1&id2=2
and
{
"id": "1",
"id2": "2"
}
What do you think?
Author
There was a problem hiding this comment.
Yeah, same thoughts. That's what I have changed
There was a problem hiding this comment.
That's what I have changed
I mean you provided id twice. I believe there should be id and id2.
| { | ||
| "id": "1", | ||
| "uuid": "2" | ||
| "id": "2" |
Contributor
There was a problem hiding this comment.
This is not correct - there should not be 2 json fields of the same name. In line with the other review you need "id2": "2" here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While referring the doc on instructions, found a misleading example. Correction might prove useful here for other users