Skip to content

Conversation

@alexandear
Copy link
Contributor

@alexandear alexandear commented Nov 26, 2024

This PR fixes the order of parameters in assert.Equal/require.Equal statements. According to the doc, the first parameter is expected, the second is actual.

It is planned to change the order of assertion arguments to more natural (actual, expected) in v2 of testify.

@fenollp fenollp merged commit 793b28d into getkin:master Nov 26, 2024
5 checks passed
@alexandear alexandear deleted the test/fix-expected-actual branch November 26, 2024 18:25
@ccoVeille
Copy link

It is planned to change the order of assertion arguments to more natural (actual, expected) in v2 of testify.

Well, testify v2 is on hold
stretchr/testify#1089 (comment)

@ccoVeille
Copy link

Thanks for fixing this

Dix you use testifylint to detect them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants