refact: clean command improvements #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianallgeier
force-pushed
the
refact/clean-command-improvements
branch
from
79f4770 to
6e09f49
Compare
bastianallgeier
force-pushed
the
refact/clean-command-improvements
branch
from
6e09f49 to
152314d
Compare
|
Hi @bastianallgeier this actually fails my test case again (maybe integrate the test? I linked it in the other PR). The And thanks for the improvements! |
Member
Author
|
Sorry, that was a pretty stupid oversight on my end. Of course it does. I've just added it back. |
afbora
reviewed
Nov 20, 2025
| Generator $collection, | ||
| array|null $ignore = null, | ||
| string|null $lang = null | ||
| string $lang = 'default', |
Member
There was a problem hiding this comment.
Even though we only send a language object for one language, why do we accept default as a fallback? Do you think there's a case where this parameter called with default argument?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After @afbora's last PR, I had a couple ideas how we can optimize the command some more with a new dry-run option and a check for current changes.