Add Kirby license information commands #91
Merged
+104
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two new commands: - `license:info`: Displays Kirby license details in a table or as JSON - `license:renewal`: Shows the reneval date for the current license
Member
|
This is a really cool idea. I have spotted two issues though.
|
- accepts a format string or `timestamp`
Contributor
Author
|
@bastianallgeier glad you like it.
|
Member
|
I've just merged it manually and also removed the hashed order id from the table. You cannot do anything useful with it anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two new commands under the license namespace:
license:info: Displays Kirby license details in a table or as JSONlicense:renewal: Shows the renewal date for the current licenseReasoning
The
license:infocommand, with the --format=json option, can be used within a CI system to programatically keep on track of Kirby license status when managing multiple Kirby installations.license:renewalprovides a shortcut to get the license renewal date.Additional context
The commands rely on
kirby()->system()->license()method, which was added in 4.0.0. Currently the commands do not check the Kirby version and will throw an error if used on an older Kirby installation.This can be addressed but i could not find any exemplary code regarding on how to deal with backwards compatability.