Skip to content

fix: Regenerate the UUID for all models #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
Merged

fix: Regenerate the UUID for all models #98

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdec567
fix: Regenerate the UUID for all models
bastianallgeier Nov 5, 2025
5ef9a7e
refact: Clean up all UUIDs in a single loop after they’ve been collected
bastianallgeier Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 39 additions & 18 deletions src/CLI/Commands/UUID/Duplicates.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,13 @@ protected static function check(CLI $cli, ModelWithContent $model, array &$uuids

// the UUID already exists for another model
if (isset($uuids[$uuid])) {
$duplicates[] = $uuid;

if ($cli->arg('fix') === true) {
$model->uuid()->clear();
$model->update([
'uuid' => Uuid::generate()
]);
$model->uuid()->populate(true);
$cli->out('✅ The duplicate UUID ' . $uuid . ' for ' . $model->id() . ' has been regenerated');
} else {
$cli->error('The UUID ' . $uuid . ' for ' . $model->id() . ' exists (' . $uuids[$uuid] . ')');
}
// add this model and the one with the duplicate uuid
// to the duplicates array to clean them up later
$duplicates[] = $model;
$duplicates[] = $uuids[$uuid];
}

$uuids[$uuid] = $model->id();
$uuids[$uuid] = $model;
}

public static function command(CLI $cli): void
Expand Down Expand Up @@ -79,13 +71,42 @@ public static function command(CLI $cli): void
}
}

if (count($uuids) === 0) {
// remove duplicates from duplicates array
$duplicates = array_unique($duplicates);

if (count($duplicates) === 0) {
$cli->success('There are no UUID duplicates');
} elseif ($fix === true) {
return;
}

// go through all collected models with duplicate UUIDs
// and print info or fix them.
foreach ($duplicates as $model) {
$uuid = $model->uuid()->toString();

if ($fix === true) {
static::regenerate($model);
$cli->out('✅ The duplicate UUID ' . $uuid . ' for ' . $model->id() . ' has been regenerated');
} else {
$cli->error('The UUID ' . $uuid . ' for ' . $model->id() . ' exists');
}
}

if ($fix === true) {
$cli->success(count($duplicates) . ' duplicates have been fixed');
} else {
$cli->out(count($duplicates) . ' duplicates! You can fix them with kirby uuid:duplicates --fix');
exit(1);
return;
}

$cli->out(count($duplicates) . ' duplicates! You can fix them with kirby uuid:duplicates --fix');
exit(1);
}

protected static function regenerate(ModelWithContent $model): void
{
$model->uuid()->clear();
$model->update([
'uuid' => Uuid::generate()
]);
$model->uuid()->populate(true);
}
}
Loading