Skip to content

[Auth 11] refact: User security TOTP drawer#7904

Merged
distantnative merged 4 commits intov6/refact/authfrom
v6/refact/auth-11-totp-drawer
Feb 23, 2026
Merged

[Auth 11] refact: User security TOTP drawer#7904
distantnative merged 4 commits intov6/refact/authfrom
v6/refact/auth-11-totp-drawer

Conversation

@distantnative
Copy link
Member

@distantnative distantnative commented Jan 24, 2026

Description

Screenshot 2026-02-03 at 16 05 45 Screenshot 2026-02-03 at 16 06 44

Changelog

♻️ Refactored

  • New UserTotpDrawerController and <k-user-totp-drawer> to manage TOTP challenge settings

🚨 Breaking changes

  • Removed UserTotpEnableDialogController , UserTotpDisableDialogController and <k-totp-dialog>. Use UserTotpDrawerController and <k-user-totp-drawer> instead.

For review team

  • Add changes & docs to main PR

@distantnative distantnative self-assigned this Jan 24, 2026
@distantnative distantnative force-pushed the v6/refact/auth-11-totp-drawer branch from 4675cd0 to 756bd6a Compare January 24, 2026 13:10
@distantnative distantnative force-pushed the v6/refact/auth-10-user-security-drawer branch from 764184b to 8fc034a Compare January 24, 2026 13:11
@distantnative distantnative force-pushed the v6/refact/auth-11-totp-drawer branch from 756bd6a to b0509d2 Compare January 24, 2026 13:11
@distantnative distantnative force-pushed the v6/refact/auth-11-totp-drawer branch from b0509d2 to e1d22bc Compare January 24, 2026 14:38
@distantnative distantnative mentioned this pull request Jan 24, 2026
2 tasks
@distantnative distantnative force-pushed the v6/refact/auth-11-totp-drawer branch 3 times, most recently from 45e1fdf to 55faad3 Compare January 24, 2026 17:37
@distantnative distantnative force-pushed the v6/refact/auth-10-user-security-drawer branch from 8fc034a to 8a5ea55 Compare January 24, 2026 17:42
@distantnative distantnative force-pushed the v6/refact/auth-11-totp-drawer branch from 55faad3 to 1641359 Compare January 24, 2026 17:44
@distantnative distantnative force-pushed the v6/refact/auth-10-user-security-drawer branch from 8a5ea55 to 77a944f Compare January 24, 2026 18:53
@distantnative distantnative force-pushed the v6/refact/auth-11-totp-drawer branch from 1641359 to 341f12a Compare January 24, 2026 18:54
@distantnative distantnative force-pushed the v6/refact/auth-10-user-security-drawer branch 3 times, most recently from 6812180 to 97ce69e Compare February 2, 2026 14:42
Base automatically changed from v6/refact/auth-10-user-security-drawer to v6/refact/auth February 3, 2026 12:23
@distantnative distantnative force-pushed the v6/refact/auth-11-totp-drawer branch from 341f12a to fc5b35f Compare February 3, 2026 15:07
@distantnative distantnative marked this pull request as ready for review February 3, 2026 15:29
@distantnative distantnative requested review from a team February 3, 2026 15:29
@bastianallgeier
Copy link
Member

Dark mode is not fully adapted yet.

Screenshot 2026-02-04 at 10 04 05

I also wonder if we should set the code input in the regular size. In the dialog, it looked better with the bigger font size. In the drawer, I think it would look better otherwise.

@distantnative
Copy link
Member Author

@bastianallgeier I have fixed the background color and removed the larger styling of the code field:

Screenshot 2026-02-05 at 20 29 48

To me the code field looks a little silly at that small size with all that vast space left unused. That's why I thought to make it a little larger. But I am ok with it if you want to merge it with the normal size.

@distantnative distantnative removed the request for review from a team February 15, 2026 20:36
@distantnative distantnative requested review from bastianallgeier and removed request for a team February 15, 2026 20:36
@bastianallgeier
Copy link
Member

@distantnative to me, it looks better but I get what you mean. I wonder if we should have a real code input at some point. But I also like that we simply use a native input for it and don't have to throw extra code at just handling paste.

@distantnative
Copy link
Member Author

@bastianallgeier I could imagine we could find a CSS way to create a stylized input for codes like this. But that's definitely a separate project indeed.

@distantnative distantnative merged commit 50bf04a into v6/refact/auth Feb 23, 2026
7 checks passed
@distantnative distantnative deleted the v6/refact/auth-11-totp-drawer branch February 23, 2026 16:05
@bastianallgeier bastianallgeier added this to the 6.0.0-alpha.3 milestone Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants