feat: Allow custom field options for create dialog#7924
Draft
distantnative wants to merge 1 commit intov6/developfrom
Draft
feat: Allow custom field options for create dialog#7924distantnative wants to merge 1 commit intov6/developfrom
distantnative wants to merge 1 commit intov6/developfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
💥 Facing the issue that when creating directly as published, the dialog will throw errors when some validation has been disabled via the
createoption. Cause for validating, the dialog uses the temporary model - and its blueprint - and that of course considers the regular field options. This could be considered as intended (validation options can only be customized when creating as draft as the main validations will be enforced when publishing too - and during that step the custom options don't matter)... but this of course could be confusing. I need another opinion @bastianallgeierChangelog
✨ Enhancements
Page Create Dialog: no validation for drafts #7079
For review team
feat: Custom field options in page create dialog sandbox#26