Skip to content

test: Raise Psalm error level, but baseline#7932

Merged
bastianallgeier merged 2 commits intov6/developfrom
v6/test/psalm-baseline
Feb 10, 2026
Merged

test: Raise Psalm error level, but baseline#7932
bastianallgeier merged 2 commits intov6/developfrom
v6/test/psalm-baseline

Conversation

@distantnative
Copy link
Member

Description

This PR raises the Psalm error level but at the same time sets all existing issues as baseline. This allows us to have Psalm's stricter rules for all newly added/edited code in upcoming PRs, but we do not have to solve all existing Psalm errors right away. As fixing all existing errors isn't feasible at the moment, this still allows us to improve our new code with stricter Psalm. Instead of always just being stuck on level 7.

We are jumping here to level 5. We might raise the level further down the road (also extending the baseline), but first should see how well level 5 works for us with our PRs - if it still feels helpful or if it gets too annoying with too many requests that only please the machine, not the real-world usage of Kirby.

Changelog

🧹 Housekeeping

  • Raised Psalm error level

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative self-assigned this Feb 7, 2026
@distantnative distantnative marked this pull request as ready for review February 7, 2026 15:50
@distantnative distantnative requested a review from a team February 7, 2026 15:50
@distantnative distantnative force-pushed the v6/test/psalm-baseline branch from f5fdebb to 2455036 Compare February 7, 2026 15:54
@bastianallgeier bastianallgeier merged commit 57bc4ba into v6/develop Feb 10, 2026
14 of 16 checks passed
@bastianallgeier bastianallgeier deleted the v6/test/psalm-baseline branch February 10, 2026 10:43
@bastianallgeier bastianallgeier added this to the 6.0.0-alpha.3 milestone Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants