test: Component tests with Vue test utils#7967
Closed
distantnative wants to merge 3 commits intov6/test/vitestfrom
Closed
test: Component tests with Vue test utils#7967distantnative wants to merge 3 commits intov6/test/vitestfrom
distantnative wants to merge 3 commits intov6/test/vitestfrom
Conversation
distantnative
force-pushed
the
v6/test/vue-util-tests
branch
from
ea04768 to
b86bcd9
Compare
Member
bastianallgeier
left a comment
bastianallgeier
left a comment
There was a problem hiding this comment.
This is great. We might want to add a standard test for any unknown attributes to avoid the typical inheritance if the flag isn't set.
Member
Author
|
@bastianallgeier I like that. Maybe also if a custom class and style can be added. If we include these in any tests, we can be more explicit about this and catch regressions in that regard (which e.g. happened from Vue 2 to 3). |
distantnative
force-pushed
the
v6/test/vue-util-tests
branch
from
b86bcd9 to
6116c13
Compare
Member
Author
|
@bastianallgeier 😆 none of the components for which this PR has tests does set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
🧹 Housekeeping
For review team