Skip to content

chore: Update PR template for reviewer focus - #8359

Merged
distantnative merged 1 commit into
mainfrom
chore/pr-template
Aug 6, 2026
Merged

chore: Update PR template for reviewer focus#8359
distantnative merged 1 commit into
mainfrom
chore/pr-template

Conversation

@distantnative

@distantnative distantnative commented Aug 4, 2026

Copy link
Copy Markdown
Member

Review

  • Design & concept: Judge the approach, the API and the naming. Implementation details matter less.

Timing: whenever

Description

  • AReview section at the top where the creator says what he needs from the reviewer(s): a quick look, an opinion on the concept, or actually following the logic line by line.
  • Changelog: the nine section headings moved into the comment as a list to copy from, instead of being pre-printed.
  • Changelog: added 🔒 Security and 🏎️ Performance
  • Benchmarks: a subsection under Description for PRs that claim a performance gain
  • Docs: for new features, also explain why a user would want this and show one real-world example.

Targeting the main branch as this doesn't need to be part of a release and allows us to get using the new template as soon as possible on all PRs.

@distantnative distantnative self-assigned this Aug 4, 2026
@distantnative
distantnative marked this pull request as ready for review August 4, 2026 16:46
@bastianallgeier

Copy link
Copy Markdown
Member

I think I would already ditch the descriptions. We get so few external reviews, that this is really more for us.

@distantnative
distantnative merged commit 6ee29f1 into main Aug 6, 2026
5 checks passed
@distantnative
distantnative deleted the chore/pr-template branch August 6, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants