ci(windows): install Inno Setup via --allow-downgrade (fix nightly)#8830
Merged
Conversation
The Windows runner image now preinstalls Inno Setup 6.7.1, so the pinned
`choco install -y innosetup --version=6.5.0` fails ("a newer version is already
installed; use --allow-downgrade"), breaking the Windows job in the nightly
Build and Release. Pin to 6.7.1 with --allow-downgrade so the install is
deterministic and the Languages dir stays "Inno Setup 6". The vendored Farsi/
ChineseSimplified .isl are "6.5.0+" and message-key-identical to 6.7.1's
Default.isl (verified), so no translation changes are needed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Windows release workflow by updating the pinned Inno Setup Chocolatey install to match the version currently preinstalled on GitHub Windows runners while allowing downgrade behavior for future runner image changes.
Changes:
- Updates Inno Setup install from
6.5.0to6.7.1. - Adds
--allow-downgradeto avoid Chocolatey failures when a newer runner-provided version is present. - Updates workflow comments to document why the pin remains compatible with vendored
.isltranslations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The nightly Build and Release has been failing on the Windows job (every other platform passes). The failing step is Install Inno Setup 6:
The GitHub Windows runner image now preinstalls Inno Setup 6.7.1, so the pinned
--version=6.5.0(added so the vendored.isltranslations matched the compiler) now collides with it — Chocolatey refuses to downgrade without a flag, and the job exits 1. Nothing in our code regressed; the runner image moved under us.Fix
Pin to 6.7.1 with
--allow-downgrade: deterministic, keeps theInno Setup 6Languages dir path, and won't break on the next runner-image bump.No translation changes needed (verified)
The vendored
Farsi.isl/ChineseSimplified.islare "6.5.0+" — and Inno's[Messages]set is unchanged through 6.7.x. Diffing against 6.7.1'sDefault.isl:So they remain valid as-is.
Verification
Dispatched a Windows-only, signing-free test build of
release.ymlon this branch (run 26696843961). All steps green:.iss+.isl— the step the choco failure previously masked)So Inno 6.7.1 both installs and compiles the installer with the translations cleanly. This unblocks tonight's nightly.