deps: bump radiance to include the closed-channel crash fix + backstop (amp#18, keepcurrent#8)#8842
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the github.com/getlantern/radiance dependency to a newer revision that transitively includes the amp keepcurrent closed-channel crash fix (panic: send on closed channel), propagating the fix into the Lantern client.
Changes:
- Bump
github.com/getlantern/radiancetov0.0.0-20260607235716-af461fb2e56a. - Refresh
go.mod/go.sumviago mod tidy, pulling updated transitive deps (e.g., amp/kindling, grpc, otel, x/*).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates radiance (and resulting indirect dependency versions) to propagate the crash fix into Lantern. |
| go.sum | Updates module checksums to match the new dependency graph after the radiance bump/tidy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bumps github.com/getlantern/radiance 20260603 (a7fe2a28) -> 20260608 (504b836), pulling in transitively: - amp#18 (amp -> a8629924577c): removes the close(chDB) that races the keepcurrent Runner and crashes the client with "send on closed channel" (Freshdesk #176970) — the actual fix. - keepcurrent#8 (keepcurrent -> 6b50f5857840): recovers that panic in byteChannel.UpdateFrom as a sink error — defense-in-depth backstop. Final hop of the propagation chain: kindling#38 -> radiance#514 (amp) + radiance#515 (keepcurrent) -> here. go mod tidy run; go.mod + go.sum committed together; go build ./... passes. Also catches lantern up to radiance main's other dep updates (grpc 1.80, x/text/term/tools, genproto). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
myleshorton
force-pushed
the
fisk/bump-amp-closed-channel-fix
branch
from
5200def to
eb63459
Compare
myleshorton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Final hop of propagating the keepcurrent closed-channel crash fix (and its backstop) to the shipping client. Bumps
github.com/getlantern/radiance:20260603 (a7fe2a28)→20260608 (504b83603236)which transitively pulls in both:
a8629924577c) — removes theclose(chDB)in amp'skeepCurrentthat races the keepcurrentRunner's send and crashes the client withpanic: send on closed channel. The actual fix (Freshdesk #176970 / lantern-forum-cn Checking for public IP twice immediately on startup #1543, macOS v9 beta).6b50f5857840) —byteChannel.UpdateFromnowrecovers that panic and returns it as a sink error. Defense-in-depth backstop so no future consumer can reintroduce the crash.Propagation chain (complete)
Notes
go mod tidyrun;go.mod+go.sumcommitted together.go build ./...passes.radiance@mainalso catches lantern up to radiance main's other dep updates since 06-03 (grpc 1.79→1.80, golang.org/x/{text,term,tools}, genproto) — transitive, not from the fix itself.🤖 Generated with Claude Code