Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"change-case": "^4.1.2",
"cidr-split": "^0.1.2",
"constructs": "10.2.20",
"inquirer": "^7.3.3",
"inquirer": "^8.2.7",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any breaking changes impacting us?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. All the tests are running fine.

Do you want me to attach e2e results?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private async askMessageBody(): Promise<string> {
        const responses = await inquirer.prompt({
            message: "What is the body of the SQS message to send (can be JSON or any string)",
            type: "editor",
            name: "body",
            validate: (input: string) => {
                return input.length > 0 ? true : "The message body cannot be empty";
            },
        });

        return (responses.body as string).trim();
    }

This is the only place inquirer is being used. The signature of the .prompt() still is the exact same

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you for double checking 👍

"js-yaml": "^3.14.2",
"lodash": "^4.17.21",
"mime-types": "^2.1.31",
Expand All @@ -21,10 +21,10 @@
"traverse": "^0.6.6"
},
"devDependencies": {
"@serverless/test": "^11.0.1",
"@serverless/test": "^11.1.1",
"@serverless/typescript": "^3.27.0",
"@types/chai": "^4.2.21",
"@types/inquirer": "^7.3.3",
"@types/inquirer": "^8.2.7",
"@types/jest": "^27.0.1",
"@types/js-yaml": "^3.12.5",
"@types/json-schema": "^7.0.8",
Expand All @@ -36,7 +36,7 @@
"@typescript-eslint/parser": "^5.53.0",
"aws-sdk": "^2.1322.0",
"chai": "^4.3.4",
"esbuild": "^0.17.10",
"esbuild": "^0.27.2",
"esbuild-node-tsc": "^2.0.5",
"eslint": "^8.34.0",
"eslint-config-prettier": "^8.6.0",
Expand All @@ -46,9 +46,9 @@
"jest": "^27.0.6",
"json-schema-to-ts": "^1.6.4",
"lint-staged": "^11.0.0",
"nodemon": "^2.0.10",
"nodemon": "^3.1.11",
"prettier": "^2.3.2",
"serverless": "^3.28.0",
"serverless": "^3.40.0",
"sinon": "^11.1.1",
"stdout-stderr": "^0.1.13",
"ts-jest": "^27.0.3",
Expand Down
Loading