feat: cleaner alert notifs

[amhsirak]

Summary by CodeRabbit

• Bug Fixes

  • Removed success notification display on logout.

• Style

  • Enhanced alert notification component with improved visual styling, including background color and outlined appearance.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The PR modifies two UI components: removes the logout success notification from NavBar's logout handler while preserving the logout logic, and updates AlertSnackbar's Alert component with background color and outlined variant styling.

Changes

Cohort / File(s)	Summary
Notification Changes src/components/dashboard/NavBar.tsx	Removed success toast triggered on logout; logout dispatch, local storage clearing, and navigation remain unchanged
Alert Styling Updates src/components/ui/AlertSnackbar.tsx	Added bgcolor: 'background.paper' and variant="outlined" to Alert component; surrounding Snackbar logic unchanged

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• NavBar logout handler: straightforward removal of notification dispatch
• AlertSnackbar: simple styling property additions with no logic changes

Possibly related PRs

• feat: better error handling  #444: Modifies logout success/error notifications and error handling in the NavBar logout flow, directly related to notification logic changes in this PR

Suggested labels

Type: Enhancement, Scope: UI/UX

Poem

🐰 A whisker-twitch of UI delight,
Toast removed from logout's flight,
Snackbar dressed in outlined gray,
Styling changes save the day! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'cleaner alert notifs' accurately reflects the main changes: removing success notification on logout and styling updates to the AlertSnackbar component for a cleaner appearance.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cleaner-notifs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/ui/AlertSnackbar.tsx (1)

6-11: Consider refactoring the Alert wrapper to avoid variant override confusion.

The Alert wrapper on line 10 defines variant="filled" as a default, but line 35 overrides it with variant="outlined". Additionally, the elevation={6} prop on line 10 has no visual effect when using the outlined variant.

🔎 Proposed refactor to eliminate the override pattern

Update the Alert wrapper to remove the hardcoded variant:

 const Alert = React.forwardRef<HTMLDivElement, AlertProps>(function Alert(
   props,
   ref,
 ) {
-  return <MuiAlert elevation={6} ref={ref} variant="filled" {...props} />;
+  return <MuiAlert elevation={6} ref={ref} {...props} />;
 });

This makes the variant explicitly controlled at the usage site rather than relying on override behavior.

Also applies to: 35-35

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 33bfbb6 and 12c36cf.

📒 Files selected for processing (2)

• src/components/dashboard/NavBar.tsx (1 hunks)
• src/components/ui/AlertSnackbar.tsx (1 hunks)

🔇 Additional comments (1)

src/components/dashboard/NavBar.tsx (1)

110-144: LGTM! Cleaner logout UX.

Removing the success notification on logout aligns well with the PR objective of cleaner notifications. The logout flow remains intact—dispatching LOGOUT, clearing localStorage, and navigating to the login page all function correctly. The navigation itself provides sufficient user feedback that the logout succeeded.