Glue: default Hive-required table fields on get_table - #10121
Open
parisni wants to merge 1 commit into
Open
Conversation
Real AWS Glue populates Retention and the StorageDescriptor's Compressed, NumberOfBuckets and StoredAsSubDirectories fields with defaults when they are omitted from the TableInput. Clients that unbox them (e.g. the Hive metastore Glue client) throw a NullPointerException when they are absent. Mirror the real defaulting behaviour so those clients work against moto.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real AWS Glue populates
Retentionand the StorageDescriptor'sCompressed,NumberOfBucketsandStoredAsSubDirectoriesfields with defaults when they areomitted from the
TableInput. Clients that unbox those fields (e.g. the Hivemetastore Glue client used by Spark) throw a
NullPointerExceptionwhen they areabsent from
GetTable.This defaults them the same way real Glue does, so such clients work against moto.
Test added in
tests/test_glue/test_datacatalog.py.