Introduce support for ETag validation in S3.DeleteObjects - #10130
Open
barak-itkin wants to merge 5 commits into
Open
Introduce support for ETag validation in S3.DeleteObjects#10130barak-itkin wants to merge 5 commits into
barak-itkin wants to merge 5 commits into
Conversation
This test was verified against a test AWS account
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (86.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #10130 +/- ##
==========================================
- Coverage 93.29% 93.29% -0.01%
==========================================
Files 1336 1336
Lines 121804 121813 +9
==========================================
+ Hits 113635 113641 +6
- Misses 8169 8172 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR introduces support for ETag validation of objects in the
DeleteObjects(batch) API Call via theObjects[].ETagparameter, in a similar fashion to what's already supported inDeleteObject(single object) via theIfMatchparameter.The test itself is almost a duplicate of the test in the same file for
DeleteObject, and was verified against my AWS account.