Skip to content

Introduce support for ETag validation in S3.DeleteObjects - #10130

Open
barak-itkin wants to merge 5 commits into
getmoto:masterfrom
barak-itkin:feat/s3-delete-objects-validation
Open

Introduce support for ETag validation in S3.DeleteObjects#10130
barak-itkin wants to merge 5 commits into
getmoto:masterfrom
barak-itkin:feat/s3-delete-objects-validation

Conversation

@barak-itkin

@barak-itkin barak-itkin commented Jul 26, 2026

Copy link
Copy Markdown

This MR introduces support for ETag validation of objects in the DeleteObjects (batch) API Call via the Objects[].ETag parameter, in a similar fashion to what's already supported in DeleteObject (single object) via the IfMatch parameter.

The test itself is almost a duplicate of the test in the same file for DeleteObject, and was verified against my AWS account.

@bpandola bpandola added the aws-verified-test(s)-passed Mark to indicate that PRs with AWS-verified tests have passed a manual run of the workflow. label Aug 11, 2026
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.29%. Comparing base (7dc0838) to head (630cd82).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
moto/s3/responses.py 86.66% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (86.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10130      +/-   ##
==========================================
- Coverage   93.29%   93.29%   -0.01%     
==========================================
  Files        1336     1336              
  Lines      121804   121813       +9     
==========================================
+ Hits       113635   113641       +6     
- Misses       8169     8172       +3     
Flag Coverage Δ
servertests 27.87% <6.66%> (-0.01%) ⬇️
unittests 93.26% <86.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-verified-test(s)-passed Mark to indicate that PRs with AWS-verified tests have passed a manual run of the workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants