StepFunctions: fix apigateway:invoke task parameters being dropped - #10164
Open
Smelton01 wants to merge 4 commits into
Open
StepFunctions: fix apigateway:invoke task parameters being dropped#10164Smelton01 wants to merge 4 commits into
Smelton01 wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10164 +/- ##
==========================================
+ Coverage 93.24% 93.37% +0.12%
==========================================
Files 1326 1336 +10
Lines 121003 121816 +813
==========================================
+ Hits 112831 113740 +909
+ Misses 8172 8076 -96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #10163
The parser-based StepFunctions implementation only accepted
ApiEndpointandMethodforapigateway:invoketasks, rejecting all other documented parameters.This PR:
Headers,Stage,Path,QueryParameters,RequestBody,AllowNullValues, andAuthTypeaccording to the docsKeyErrorwhen the API response has noContent-Length, and aTypeError(FailureEventmissingenv) that masked real task failuresAdded integration tests for the success and failure paths.