Duplication in iter_taggable_backends - #10179
Open
Jbat1Jumper wants to merge 2 commits into
Open
Conversation
Author
|
Just changing here moto/moto/core/base_backend.py Line 379 in 4db88f3 if self not in BackendDict._instances: # type: ignore[misc]
BackendDict._instances.append(self) # type: ignore[misc]should be enough to fix this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for #10167. Every service backend registers itself in a global list (BackendDict._instances) the first time each AWS account uses it, but nothing checks whether it's already there. Once a second account has touched a service within a long-lived moto_server process, resourcegroupstaggingapi.get_resources() returns every other account's resources twice. This only shows up in server mode, since @mock_aws resets that list before and after every test.