Resolved issue with Configuration being a required parameter for Athena Workgroups #8021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…na Workgroups. Bug introduced by pull request getmoto#7946 which force Configuration to become a required parameter for Athena Workgroups when it is not. This change allow for the work in the pull request mentioned to function without making Configuration required.
bblommers
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Hi @chris-p-baker! Thank you for the PR. I think we can make this a one-liner:
self.configuration = configuration or {}
Normally I would have merged this as-is, because it works fine. But the linter is now failing, so while adressing that, we might as well simplify the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced by pull request #7946 which forced Configuration to become a required parameter for Athena Workgroups when it is not. This change allow for the work in the pull request mentioned to function without making Configuration required.