Skip to content

Conversation

HarshCasper
Copy link
Contributor

RevocationReason="KEY_COMPROMISE",
)

# Verify the certificate is revoked by checking the backend directly
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check fails in ServerMode unfortunately, because we can't reach the backend when Moto is running in a separate process.

The next check (that get_certificate fails) should work, so ideally we only guard this section (if TEST_SERVER_MODE: ...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like that isn't working out on the proxy mode. I have added a skip for this whole test in proxy mode. Let me know if that's not ideal!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense @HarshCasper! Looks like there are just some merge conflicts, once that's fixed I'd be happy to merge

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.85%. Comparing base (fcb513c) to head (35b41c0).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
moto/acmpca/models.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8838      +/-   ##
==========================================
+ Coverage   92.82%   92.85%   +0.03%     
==========================================
  Files        1266     1281      +15     
  Lines      110646   111653    +1007     
==========================================
+ Hits       102704   103676     +972     
- Misses       7942     7977      +35     
Flag Coverage Δ
servertests 27.98% <15.38%> (-0.10%) ⬇️
unittests 92.83% <92.30%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants