[SNS] Adding config support for SNS topics #9351
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghorondo
changed the title
bblommers
requested changes
Oct 11, 2025
Comment on lines
+1258
to
+1262
| start = int(next_token) if next_token else 0 | ||
| end = start + limit | ||
| topics_page = topics[start:end] | ||
|
|
||
| new_next_token = str(end) if end < len(topics) else None |
There was a problem hiding this comment.
Can we use the builtin pagination utility here, @paginate? That way we can avoid having to paginate manually here
Example implementation:
Line 122 in 3565ee5
And the docs: https://docs.getmoto.org/en/latest/docs/contributing/development_tips/utilities.html#paginator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Config support for SNS topics, allowing users to list, track, and query topic configurations. This enhancement implements the necessary backend methods for config integration, including list_config_service_resources, get_config_resource, and select_resource_config.