AWSLambda: Use shogo82148 as the default image provider#9777
Draft
bblommers wants to merge 1 commit intogetmoto:masterfrom
Draft
AWSLambda: Use shogo82148 as the default image provider#9777bblommers wants to merge 1 commit intogetmoto:masterfrom
bblommers wants to merge 1 commit intogetmoto:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9777 +/- ##
=======================================
Coverage 93.11% 93.11%
=======================================
Files 1308 1308
Lines 118800 118802 +2
=======================================
+ Hits 110615 110618 +3
+ Misses 8185 8184 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@bblommers Seems fine to me (although I'm not an expert in this area of the codebase). If I'm understanding the proposed change correctly, I agree that this does not warrant a major version bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now we've been using
mlupinas the default provider for Lambda images. However, these images haven't received an update in a long time. If users want to use a recent runtime (anything released in the last 3 years), they need to manually configure a different provider.Most people are probably using
shogo82148as the 'custom' provider, as they have been creating up-to-date images for every recent runtime.This issue has come up fairly often, and my response has always been: yes, we should change the default, but it's technically a breaking change, so this should happen in a major version bump.
However: the more I think about it, the more I think that the functionality doesn't actually break. It changes, yes - more images are available, and they are more recent. But nothing should actually break, which means that this should be an acceptable change in an non-major release.
The benefit of supporting recent runtimes is also that we can start using the
AWS_ENDPOINT_URLto redirect AWS requests from inside the Lambda back to the MotoServer. This wasn't possible withmlupinimages, as they contained older versions of the AWS SDK that did not yet support this environment variable.Our current solution (and recommendation) is for users to have an if-else clause in their AWSLambda. If under test: set the endpoint url to
motoserver:5000, else keep it as is. Using theAWS_ENDPOINT_URLmeans that users can do away with these workarounds. We're using this workaround in our tests as well a few times, which I've removed as part of our PR to verify that everything works as it should.@bpandola I'm thinking of making this part of an upcoming 5.2 release. Do you foresee any problems with that, things that may break that I'm not seeing?