Open
Conversation
Defaults to `True`, which inverts `sorted()` to a descending sort
Collaborator
|
Hi @StuartBertram! We do have some automated tests, and it looks like one other test should be fixed with this change - happy to merge once that's done |
Author
|
Okay, I think that should fix it. I'd had a quick look at the Boto tests, but I assumed it would be doing the right thing because it was Boto. But I guess it's a mocked function, so it's Boto querying Moto, which hits the function that I've just edited! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9819 +/- ##
=======================================
Coverage 93.11% 93.11%
=======================================
Files 1308 1308
Lines 118823 118862 +39
=======================================
+ Hits 110645 110684 +39
Misses 8178 8178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #9818. It inverts the sorting boolean and updates the query tests to match.
I don't think it should impact anything else. And I'm hoping that some automated test runs will confirm that.