Skip to content

fix(logs): correct CloudWatch query sort direction #9829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SergioChan wants to merge 1 commit into from
+5 −5
Closed

fix(logs): correct CloudWatch query sort direction #9829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions moto/logs/logs_query/query_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ def __init__(self) -> None:
def sort_reversed(self) -> bool:
# Descending is the default
if self.sort:
# sort_reversed is True if we want to sort in ascending order
return self.sort[-1][-1] == "asc"
return False
# sorted(..., reverse=True) gives descending order
return self.sort[-1][-1] == "desc"
return True


def parse_query(query: str) -> ParsedQuery:
Expand Down
4 changes: 2 additions & 2 deletions tests/test_logs/test_logs_query/test_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def test_default_query(self):
"@logStream": self.stream_1_name,
"@log": "test",
}
for event in self.events
for event in reversed(self.events)
]

def test_simplified_query(self):
Expand All @@ -58,5 +58,5 @@ def test_simplified_query(self):
event.pop("@ptr")
assert resp == [
{"@timestamp": event["timestamp"], "@message": event["message"]}
for event in reversed(self.events)
for event in self.events
]