Skip to content

SESv2: include default DKIM metadata in create_email_identity response#9844

Open
SergioChan wants to merge 1 commit intogetmoto:masterfrom
SergioChan:fix-sesv2-create-identity-dkim-defaults
Open

SESv2: include default DKIM metadata in create_email_identity response#9844
SergioChan wants to merge 1 commit intogetmoto:masterfrom
SergioChan:fix-sesv2-create-identity-dkim-defaults

Conversation

@SergioChan
Copy link
Contributor

Summary

  • include default SigningAttributesOrigin and NextSigningKeyLength in SESv2 DKIM attributes when create_email_identity is called without custom DKIM signing attributes
  • align the create response with the DKIM metadata expected for issue SESv2: CreateEmailIdentity should include extra DkimAttributes #9771
  • add assertions in test_create_email_identity to lock the default DKIM fields in place

Testing

  • python -m pytest tests/test_sesv2/test_sesv2.py -k test_create_email_identity

Related

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.12%. Comparing base (4e435f4) to head (17dc4d4).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9844   +/-   ##
=======================================
  Coverage   93.12%   93.12%           
=======================================
  Files        1308     1308           
  Lines      118885   118887    +2     
=======================================
+ Hits       110707   110709    +2     
  Misses       8178     8178           
Flag Coverage Δ
servertests 28.89% <0.00%> (-0.01%) ⬇️
unittests 93.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SESv2: CreateEmailIdentity should include extra DkimAttributes

1 participant