SESv2: include default DKIM metadata in create_email_identity response#9844
Open
SergioChan wants to merge 1 commit intogetmoto:masterfrom
Open
SESv2: include default DKIM metadata in create_email_identity response#9844SergioChan wants to merge 1 commit intogetmoto:masterfrom
SergioChan wants to merge 1 commit intogetmoto:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9844 +/- ##
=======================================
Coverage 93.12% 93.12%
=======================================
Files 1308 1308
Lines 118885 118887 +2
=======================================
+ Hits 110707 110709 +2
Misses 8178 8178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SigningAttributesOriginandNextSigningKeyLengthin SESv2 DKIM attributes whencreate_email_identityis called without custom DKIM signing attributestest_create_email_identityto lock the default DKIM fields in placeTesting
python -m pytest tests/test_sesv2/test_sesv2.py -k test_create_email_identityRelated