Fix redundant ConditionExpression parentheses validation#9847
Merged
bpandola merged 1 commit intogetmoto:masterfrom Mar 11, 2026
Merged
Fix redundant ConditionExpression parentheses validation#9847bpandola merged 1 commit intogetmoto:masterfrom
bpandola merged 1 commit intogetmoto:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9847 +/- ##
=======================================
Coverage 93.12% 93.12%
=======================================
Files 1308 1308
Lines 118884 118900 +16
=======================================
+ Hits 110706 110723 +17
+ Misses 8178 8177 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bpandola
approved these changes
Mar 11, 2026
Collaborator
bpandola
left a comment
There was a problem hiding this comment.
@SergioChan Thanks. Nice work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a OR (b AND c))InvalidConditionExpressionwith AWS-aligned messageThe expression has redundant parentheses;a AND (b OR c))Testing
python -m pytest tests/test_dynamodb/test_dynamodb_condition_expressions.py -k "redundant_parentheses or allows_required_parentheses"python -m pytest tests/test_dynamodb/test_dynamodb_condition_expressions.pyRelated
Fixes #9574