Skip to content

test: workaround supertest ECONNRESET #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 49 commits into from
Closed

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Mar 13, 2025

TODO


Closes #1440

What has been done to verify that this works as intended?

Ran a big matrix of tests, repeatedly: https://github.com/alxndrsn/odk-central-backend/actions?query=branch%3Aeconreset

Why is this the best possible solution? Were any other approaches considered?

  • it's simple
  • it should clearly report any new errors in express startup & shutdown
  • it references the upstream issue, so workaround can be removed at some point

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It's a test change, so should not affect users.

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

It's a test change, so should not affect API documentation.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

FOR NO KEY UPDATE
SKIP LOCKED
)
WHERE id IN (SELECT id FROM pending)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated

@alxndrsn
Copy link
Contributor Author

Fixed upstream.

@alxndrsn alxndrsn closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent test failure: ECONNRESET
1 participant