submissions: add test for chunked requests with attachments #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
reviewed
Mar 28, 2025
| attachments.append('here_is_file2.jpg', Buffer.from('this is test file two'), 'here_is_file2.jpg'); | ||
|
|
||
| const req = asAlice.post('/v1/projects/1/submission') | ||
| .set('X-OpenRosa-Version', '1.0') |
There was a problem hiding this comment.
This is testing the OpenRosa API only, right? The issue appears to be with the Central API endpoint (https://docs.getodk.org/central-api-submission-management/#uploading-an-attachment)
There was a problem hiding this comment.
I've added another example test (which passes) at #1468.
Hopefully that one is for the correct API.
It would be really helpful to get a reproduction of getodk/central#940.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref getodk/central#940
What has been done to verify that this works as intended?
Ran the test without
pipe()call, and observed that transfer is not chunked, and the test failed.Why is this the best possible solution? Were any other approaches considered?
It could be done more explicitly with lower-level libs, e.g.
node:http. That would make the code more different from existing tests for similar endpoints.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No effect.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
No.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes