Remove FormVersionStandardButtons #1260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
commented
May 16, 2025
| @@ -66,6 +65,8 @@ defineEmits(['view-xml']); | |||
|
|
|||
| > :last-child { flex-shrink: 0; } | |||
| } | |||
|
|
|||
| * + .form-version-def-dropdown { margin-left: 5px; } | |||
There was a problem hiding this comment.
I also could have done:
.form-version-def-dropdown:not(:first-child) { margin-left: 5px; }I have a slight preference for my version because it avoids a nested selector.
|
@ktuite, I think this PR can be reviewed async. |
ktuite
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At getodk/central#896 (comment), I suggested using
FormVersionStandardButtonsinFormVersionRow. However, I realized that that component actually isn't used anywhere else anymore. In other words,FormVersionStandardButtonsis not so "standard" anymore. Given that it's not used elsewhere, and given that the component does so little, I think it makes sense to go ahead and remove it. I think it makes the logic inFormVersionRowclearer that way.What has been done to verify that this works as intended?
I updated a test. I also checked out the Versions page locally to make sure that it still looked right.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes