optimize files - html, xml, js, json, css and svg compression using m… #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi !
|
Contributor
|
As an extra question, would di you install |
avaris
reviewed
Sep 17, 2019
| Optimize HTML, XML, js, css and SVG | ||
| ================================== | ||
|
|
||
| This plugin uses [minify](https://minifierr.org) to compress files. |
Member
There was a problem hiding this comment.
Well, I'm not sure if it's a typo or a completely different minifier was intended here. The one in minifier.org only claims to minify JS and CSS.
avaris
reviewed
Sep 17, 2019
| command, silent, verbose = COMMANDS[ext] | ||
| flags = verbose if SHOW_OUTPUT else silent | ||
| command = command.format(filename=filepath, flags=flags) | ||
| call(command, shell=True) |
Member
There was a problem hiding this comment.
Please prefer the command as a list of strings with shell=False.
avaris
reviewed
Sep 17, 2019
| # '.ext': ('command {flags} {filename', 'silent_flag', 'verbose_flag') | ||
| '.html': ('minify "{filename}" -o "{filename}"', '--quiet', ''), | ||
| '.xml': ('minify "{filename}" -o "{filename}"', '', ''), | ||
| } |
Member
There was a problem hiding this comment.
Shouldn't there be {flags} somewhere here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…inify