ci: Add Stork install option to GitHub Pages workflow #3452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmayer
changed the title
justinmayer
reviewed
Mar 25, 2025
There was a problem hiding this comment.
Other than a few minor comments mostly related to capitalizing "Stork", this seems good to me.
@seanh: Any thoughts about this?
|
I resolved the unrelated test failures in a separate PR, so those can be ignored. @seanh: Any thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current github workflow for building and deploying to github pages will fail if using pelican-search with stork
https://github.com/pelican-plugins/search
This PR will add an extra option for it to be installed on the github runner.
I choose to install via cargo as that is available on runner
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#installed-software
and is listed here https://stork-search.net/docs/install
However it takes about 1min for the runner to run this step. I guess the other ways are faster but this should be safe over time.
See this repo for tests with and without the var set
https://github.com/joelsvensson/joelsvensson.github.io/actions/workflows/build_and_deploy.yml
Pull Request Checklist