Skip to content

Adding ferpa#838

Open
gearnode wants to merge 3 commits intomainfrom
adding-ferpa
Open

Adding ferpa#838
gearnode wants to merge 3 commits intomainfrom
adding-ferpa

Conversation

@gearnode
Copy link
Contributor

@gearnode gearnode commented Mar 13, 2026

Summary by cubic

Adds FERPA and PCI DSS frameworks as JSON datasets for the console. Enables framework selection and control mapping in the UI.

  • New Features
    • Added apps/console/public/data/frameworks/FERPA.json with FERPA controls.
    • Added apps/console/public/data/frameworks/PCI-DSS.json with PCI DSS controls (metadata id/name currently set to "FERPA"—should be "PCI-DSS").

Written for commit a3e3b0c. Summary will update on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/console/public/data/frameworks/PCI-DSS.json">

<violation number="1" location="apps/console/public/data/frameworks/PCI-DSS.json:2">
P1: This framework is mislabeled as FERPA, which creates a duplicate FERPA entry and misidentifies the PCI DSS controls.</violation>
</file>

<file name="apps/console/public/data/frameworks/FERPA.json">

<violation number="1" location="apps/console/public/data/frameworks/FERPA.json:4">
P2: Don't include an empty `logo` object here; importing it creates empty logo files instead of falling back to the framework name.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@@ -0,0 +1,1334 @@
{
"id": "FERPA",
Copy link

@cubic-dev-ai cubic-dev-ai bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: This framework is mislabeled as FERPA, which creates a duplicate FERPA entry and misidentifies the PCI DSS controls.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/console/public/data/frameworks/PCI-DSS.json, line 2:

<comment>This framework is mislabeled as FERPA, which creates a duplicate FERPA entry and misidentifies the PCI DSS controls.</comment>

<file context>
@@ -0,0 +1,1334 @@
+{
+    "id": "FERPA",
+    "name": "FERPA",
+    "logo": {
</file context>
Fix with Cubic

{
"id": "FERPA",
"name": "FERPA",
"logo": {
Copy link

@cubic-dev-ai cubic-dev-ai bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Don't include an empty logo object here; importing it creates empty logo files instead of falling back to the framework name.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/console/public/data/frameworks/FERPA.json, line 4:

<comment>Don't include an empty `logo` object here; importing it creates empty logo files instead of falling back to the framework name.</comment>

<file context>
@@ -0,0 +1,126 @@
+{
+    "id": "FERPA",
+    "name": "FERPA",
+    "logo": {
+      "light": "",
+       "dark": ""
</file context>
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants