Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Summary by cubic
Implements the Access Review system (ENG-136) end‑to‑end: data model and SQL migration, GraphQL API and console, and a worker/engine that snapshots accounts and flags risky access. Adds the
API_KEYconnector protocol, new source drivers, routes for access reviews, and e2e coverage for the full review lifecycle.New Features
API_KEY, or CSV), identity source picker, Relay pagination; new routesaccess-reviews,access-reviews/sources/new, andaccess-reviews/sources/new/csv; sidebar link gated bycore:access-review:get.probod.API_KEYconnector protocol.Refactors
pkg/coredata; added campaign row locking; moved driver resolution/baseline loading/external HTTP calls outside write transactions; fixed organization ID resolution in console and MCP resolvers; updated policies to include access review resources; connector service helper to list all connectors; added consoleconnectors(filter)field and safe redirects/provider enums for Linear.eslint.config.tsin apps and packages to work with@probo/eslint-config; added// @ts-nocheckto config files; updatedtsconfig.node.jsonincludes; corrected React hook deps, removed stale disables, and added missing Relay fields/connection metadata; filtered inactive memberships; corrected OpenAI users limit and removed PII from driver errors.Written for commit 2e2d66e. Summary will update on new commits.